Skip to content

Use group crate for curve traits and wNAF#91

Closed
str4d wants to merge 2 commits into
zkcrypto:masterfrom
str4d:group
Closed

Use group crate for curve traits and wNAF#91
str4d wants to merge 2 commits into
zkcrypto:masterfrom
str4d:group

Conversation

@str4d

@str4d str4d commented Jul 5, 2018

Copy link
Copy Markdown
Member

No description provided.

@str4d str4d mentioned this pull request Jul 6, 2018
Closed
@str4d str4d mentioned this pull request Nov 10, 2018
Merged
daira
daira approved these changes Jan 21, 2019
View reviewed changes

@daira daira left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Eirik0
Eirik0 approved these changes Feb 6, 2019
View reviewed changes

@Eirik0 Eirik0 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Eirik0

Eirik0 commented Feb 6, 2019

Copy link
Copy Markdown

As a note, we get the following warning when compiling, but this also happens in master:

warning: unused `#[macro_use]` import
  --> src/lib.rs:15:1
   |
15 | #[macro_use]
   | ^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

@str4d

str4d commented Apr 11, 2019

Copy link
Copy Markdown
Member Author

This was pulled into pairing in zcash/librustzcash#46 and will be upstreamed back to this repository once the pairing refactor (part of zcash/librustzcash#41) is complete.

@str4d str4d closed this Apr 11, 2019
ebfull pushed a commit that referenced this pull request Oct 8, 2019
@str4d
Fix pairing benchmarks
0de7279 
They were broken by #91 but went unnoticed because CI does not compile
the benchmarks, which requires the nightly toolchain.
str4d added a commit that referenced this pull request Aug 25, 2020
@str4d
Merge pull request #91 from str4d/upgrade-rand
05f098e 
Upgrade rand crate dependency to 0.7
str4d added a commit that referenced this pull request Aug 25, 2020
@str4d
Fix pairing benchmarks
b872e9f 
They were broken by #91 but went unnoticed because CI does not compile
the benchmarks, which requires the nightly toolchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daira daira daira approved these changes

+1 more reviewer

@Eirik0 Eirik0 Eirik0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@str4d @Eirik0 @daira